Hide dashboard reports from Report Generator #1445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plessbd
force-pushed
the
hide-dashboard-reports
branch
3 times, most recently
from
97d65ec
to
7ad9098
Compare
plessbd
force-pushed
the
hide-dashboard-reports
branch
from
7ad9098
to
210807a
Compare
plessbd
force-pushed
the
hide-dashboard-reports
branch
from
210807a
to
1846093
Compare
plessbd
commented
Sep 10, 2020
| @@ -1034,8 +1034,8 @@ class ReportGenerator { | |||
| browser.waitForVisible(this.selectors.myReports.toolbar.downloadAsPdfButton()); | |||
| browser.click(this.selectors.myReports.toolbar.downloadAsPdfButton()); | |||
| // Wait for check mark image to appear and disappear. | |||
| browser.waitForVisible(this.selectors.checkmarkMask(), 10000); | |||
| browser.waitForInvisible(this.selectors.checkmarkMask(), 10000); | |||
| browser.waitForVisible(this.selectors.checkmarkMask(), 60000); | |||
There was a problem hiding this comment.
Timings on a "fresh" install in my local docker (27.27, 8.11, 6.65, 11.52)
|
How have you tested this to confirm that the dashboard reports are still working? |
|
modifying metrics-dev and logging in as a center director and normal user. and of course in the docker |
jpwhite4
approved these changes
Sep 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dashboard tab reports are special templates that are not meant to have reports generated from them. This hides them from the report generator drop down.